- Tests: the four known failures fixed (test-side causes), one duplicate file and four detail-pinning cases removed, every test that pins behaviour the restructure changes tagged with its step. - Every toast, sound and activity-log line goes through Notifier.notify (AppEvent), mapped one-to-one to today's behaviour. - Platform ports (shell, URLs, folders, link resolver, system notifications) with desktop implementations; window_manager, Process and file_picker now live only in platform/desktop/. - ROADMAP: protocol 16 planned; app id dev.foxyz.starsync. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
14 KiB
Development
Layout and rules: ARCHITECTURE.md.
Build
Needs the Flutter SDK (beta channel, Dart 3.13+) and, for the Linux desktop
build, the usual GTK toolchain (clang, cmake, ninja, pkg-config, libgtk-3-dev).
mpv libraries come from media_kit_libs_video. flutter_soloud (the app's
sounds) compiles SoLoud and miniaudio from source in its build hook with
that C++ toolchain (MSVC on Windows); it needs no audio dev headers (miniaudio
loads ALSA / PulseAudio / JACK at run time) and, with no_xiph_libs set in
the desktop pubspec, downloads nothing. fox_utils (drag & drop,
clipboard files and images; native Linux/Windows plugin) is the owner's
shared package, a git dependency pinned to a tag of
git.senkochan.moe/Foxyz/fox_utils: bump it by tagging there and changing
ref in the desktop pubspec.
cd apps/desktop && flutter pub get && flutter run -d linux
cd apps/desktop && flutter build linux --release --dart-define=APP_VERSION=<x.y.z>
tool/package_linux.sh [--skip-build] [--noupload] # dist/*.tar.gz
powershell -File tool/package_windows.ps1 [-SkipBuild] # dist/*.zip (on Windows)
cd packages/server && dart compile exe --define=APP_VERSION=<x.y.z> bin/server.dart -o watch-together-server
APP_VERSION defaults to 0.0.0-dev; the packagers stamp it from the
desktop pubspec into both the app and the server. tool/package_linux.sh
also passes GIT_COMMIT (what the app shows: "Updater" in
ARCHITECTURE.md). Setting DISCORD_WEBHOOK_URL makes the packager post the
tarball to Discord (never commit it). The packager always compiles the
dedicated server (with the Flutter SDK's dart) into the tarball as
watch-together-server, also with --skip-build.
Dev loop
Run a server without the app, then point apps at it:
dart run packages/server/bin/server.dart --port 8080 --secret x [--media FILE]
This is the same serve() the app runs when hosting and the same code as
the dedicated binary. Prints READY port=... name=... and stops on SIGINT
or SIGTERM. Then Join from one or more apps at 127.0.0.1:8080. Or just
Host from the app. mpv env override:
SYNC_RELAY_HWDEC (wins over the Settings choice). SYNC_RELAY_VO has no
effect with embedded video: media_kit forces vo=libmpv. SYNC_RELAY_PRELOAD=0
turns Up next's preload player off; SYNC_RELAY_TRACE_SWITCH=1 prints
the timings of each media change (SwitchTrace).
Harnesses in tool/ (own pubspec.yaml, dart run tool/<name>.dart):
range_logger (serve a file and log every Range request), shaper
(bandwidth cap, latency, --kill-after for outage tests), fake_viewer
and e2e_check (simulated viewers against a live server).
Tests
Three suites, run from each package's folder:
cd packages/core && dart test(a few seconds): protocol round-trips, the sync engine (clock, gate, correction, end of file), queue model, relay pieces, updater, logging redaction, watch rule, yt-dlp and Jellyfin client parsing against captured fixtures.cd packages/server && dart test(well under a minute): live servers on loopback: auth, media and relay byte serving, Jellyfin relay against a fake, queue, session log, isolateserve.cd apps/desktop && flutter test test/<file>: widgets (shell, library, controls, settings, schedule), pure app logic (StateDiff, name parser, shader list, sound engine with a fake backend) and the real-mpv*_e2etests pluscoord_presence. The whole suite takes a couple of minutes; run it only before a restructure step lands, otherwise only the files related to what you changed.
Opt-in, skipped unless set: JELLYFIN_TEST_* (core jellyfin_live and
server jellyfin_relay_live against a real Jellyfin; read their headers),
YTDLP_LIVE=1 (downloads yt-dlp and resolves a real tweet). Everything
else is offline: Jellyfin and link hosts are local fakes.
Real-mpv tests: sync_playback_e2e, coord_presence, video_reload_e2e,
seek_drag_e2e, end_of_file_e2e, readahead_e2e, chapters_mpv_e2e,
ytdl_headers_e2e, relay_e2e (a dedicated server with no file of its
own: a guest's file, links passed on or fetched by the server, a late
source, a source that drops and resumes), jellyfin_e2e,
queue_switch_e2e (times Up next switches against a delayed, rate-capped
fake Jellyfin and link host: an episode, a direct link, a link passed on
and a server-fetched one; WT_SWITCH_PRELOAD=0 for the cold path,
WT_SWITCH_DELAY_MS / WT_SWITCH_RATE_KBS for the link). The sync,
reload and end-of-file ones expect ~/Videos/chiyo.mp4; the others
generate media with ffmpeg into WT_TEST_TMP (default: system temp; all
desktop tests that write files use it). Headless mpv (no video output
attached) won't open video-only files, so test media needs an audio
track. Tests always log media_kit "S/W rendering" because they have no
display; that says nothing about the app. sound_device_e2e opens the
real audio device (flutter_soloud) and plays every sound of every preset
quietly (WT_SFX_VOLUME, default 0.1).
A test file whose first line is // restructure: rewrite in step N pins
behaviour that step of the restructure (ROADMAP.md) changes;
the comment names the tests. Rewrite or delete them in that step, not
before.
CI (.gitea/workflows/ci.yml): analyze + test for core and server, plus
dart compile exe of the dedicated server (fails if Flutter creeps into
packages/server). Desktop tests are not in CI.
Traps:
- Never pump media_kit's
Videoinflutter test: the runner hangs (kill theflutter_testerby PID).AppShell(videoBuilder:)takes a stand-in, so shell tests run the real player layout without it; otherwise test pure logic (StateDiff, coordinator without widgets). - A
SyncServerstarted inside a test: relic reports an error writing a response (a relay response cut short when its relay is dropped at a swap or stop) to the zone the server started in, which fails the test; outside tests it is only logged. Start it inrunZonedGuardedand fail on anything else (queue_switch_e2e,relay_e2e): a viewer's read is still in flight at thestopin tearDown. - The Link page probes a filled-in link (network, yt-dlp), which never
answers on the widget-test clock: pass
AppShell(linkProbe:)/LibraryTab(probe:)a fake, orpumpAndSettlenever returns. - Never depend on a server-side WebSocket
onDone; assert presence with deadline polling. sub.asFuture()can resolve beforeonDone; poll with a deadline.- Tests must not assume a threat model beyond the friends trust basis.
Releasing
User pushes tags; CI does the rest.
tool/release.sh [patch|minor|major] [--dry-run]: derives the next version from the latest tag, bumps the three pubspecs in lockstep, writesupdates/manifest.json(per-platformassetsURLs are predictable;urlstays the Linux tarball for builds <= 0.2.1), commitsRelease vX.Y.Z, makes an annotated tag.- Review, then
git push --follow-tags. .gitea/workflows/release.ymlruns one job per platform: Linux builds withtool/package_linux.sh, Windows (runneryuuka-windows, host mode, PowerShell only) withtool/package_windows.ps1. Each then runsdart tool/release_publish.dart vX.Y.Z <archive>, which creates the release if the other job hasn't yet and uploads (or replaces) its asset. By hand: package, then the samedart tool/release_publish.dartline.
Test builds (Linux, no tag, no CI): tool/dev_release.sh [--minor|--major] [--no-publish] (token: RELEASE_TOKEN or
~/.config/watch-together-release-token, a Gitea access token with
repository read/write) builds the working tree here as <next>-dev.N (N
one past the published one; <next> the pubspec's next patch, or next
minor / major when asked, and once such a line is published later runs
follow it until a release moves the pubspec) and replaces the assets of the
dev prerelease with the tarball and its manifest.json. Dev builds
update from it (Updater). A stable install
moves onto it once with the command the script prints (run with the app
open: it finds the install from the running process and copies the new
files over it).
Tokens come from the environment (RELEASE_TOKEN, or Actions-provided
GITHUB_TOKEN/GITEA_TOKEN). The manifest has no sha256 by default; the
updater skips the check when absent. Workflows live in .gitea/workflows
(the forge reads .gitea before .github).
Debugging the hosted server
When hosting, the server runs on its own isolate (ServerIsolate,
apps/desktop/lib/src/state/server_isolate.dart), in the same process.
Breakpoints in packages/server work under flutter run: the debugger
attaches to spawned isolates too (it shows as server). Its log lines
carry server.<logger> (e.g. server.relay). Hot reload reloads the server isolate's
code too, but its state (members, clock, sockets) survives until hosting
restarts; changes to startup code (SyncServer.start, routes) need a new
Host. Hot restart kills the server isolate (flutter_tools kills every
non-UI isolate first), so a [server] server crashed: the server stopped unexpectedly line just before it is expected. Without the app:
dart run packages/server/bin/server.dart.
Logs
After a session, read the log files rather than reproducing
("Logging" in ARCHITECTURE.md has what goes in them):
the app's are ~/.local/share/moe.senkochan.watch_together/logs/app-*.log
on Linux (on Windows under %APPDATA%; Settings → About → "Open logs
folder" finds it anywhere), with the hosted server's lines
in the same file; a dedicated server prints its folder at start
(--log-dir). Users send theirs with Settings → About → "Copy
diagnostics".
Start with the session log when there is one: session-YYYY-MM-DD.log
in the server's folder (the hosting app's logs folder, or the dedicated
server's --log-dir), every member's lines and the server's merged in
server-clock order, each tagged [name (id)] or [server]. Any member
gets it with "Copy diagnostics" in a session. Find
=== PROBLEM marked by first (a member pressed Ctrl+Shift+B), then read
the lines around it from every side; grep '\[Bob (m2)\]' follows one
member. [server] diag: lines say who shares (with their app version)
and who doesn't, so a missing side is explained. Times are the server's
clock; a member's local log (app-*.log) is on its own clock.
For a "can't play" report, grep both sides around the
time: swap by (what went up and how), relay channel (when the
source dialled in), media: (each viewer's requests: status and time to
headers), mpv: (cannot open the media and ffmpeg's lines), yt-dlp:
(the resolve and its picked formats) and upstream (CDN refusals with
the headers sent). A viewer that got no bytes while the source was
slow to come up shows mpv's error with "no HTTP error logged".
For "the video is slow / shaders do nothing", grep mpv: render (what
each line holds: "Render mode" in ARCHITECTURE.md).
render: gpu with a real GL_RENDERER (not llvmpipe / softpipe) is
the good case; render: softwareGl is OpenGL on the CPU (Mesa's software
rasterizer: missing or blocked GPU drivers, LIBGL_ALWAYS_SOFTWARE=1);
render: software with no GL lines is media_kit's own fallback (it found
no usable EGL context: check render env: for an X11 session or a
GDK_BACKEND / FLUTTER_LINUX_RENDERER override). Its reason is only on
stderr: have the user start the app from a terminal
(watch-together 2>&1 | grep VideoOutput). hwdec-current=no on the
first-frame line means software decoding (no hwdec for that codec, or it
is off), not software rendering.
Gotchas
- Relic gives Range as a typed
RangeHeader; convert from unit + first range. - A killed isolate (
Isolate.kill) does not close its listening socket: the port stays bound in the process until exit.SyncServerbinds withshared: trueso a new hosted server in the same process can take it over; a normal stop closes it. - Relic server-side
onDonedoes not fire for dead peers. Presence is theisClosedsweep +onErrorforget +lastSeentimeouts. web_socket_channel3.x:channel.readyerrors are unhandled on refused connections; swallow them and report through the stream'sonError. Streams are single-subscription: one listener per socket.- media_kit has no public
Player.setProperty; the code reaches mpv through a dynamic call onplayer.platform. Cache size goes throughPlayerConfiguration(bufferSize:). - Hot restart with any media_kit
Playeralive (session, thumbnails) used to SIGSEGV on mpv'scorethread: each mpv handle's wakeup callback is aNativeCallableof the old isolate, freed by the restart, and media_kit then sends the leftover handlesquit, which fires it.fox_utils' Linux plugin (from 0.1.8, debug builds only) clears those callbacks on the engine'son-pre-engine-restartsignal, reading the handles from media_kit's debug-onlyNativeReferenceHolderbuffer (address in$TMPDIR/com.alexmercerind.media_kit.NativeReferenceHolder.<pid>). Old players are leaked, not destroyed, until the process exits. Re-check this after a media_kit upgrade. - mpv reconnect flags: comma form works, colon form is rejected. Re-verify
through
setPropertyif touched. - Overlays that are hidden but mounted keep focus (Space falls into a hidden
button). Use
ExcludeFocuson closed subtrees and unfocus on close; reuse the shared no-focus node for overlay buttons. toggleFullscreenOnDoublePress: falseon the session controls is load-bearing: media_kit's double-click pushes its own fullscreen route with a secondVideo. AGestureDetectorbelow media_kit's overlay never sees the click (itsMouseRegiontakes the hit) and one around it would delay every button click (double-tap holds the arena), so the double-click is a raw pointer observer (DoubleClickListener).- The window is frameless: the party strip is the only drag area and holds the window buttons.
- Signal-backed singletons (
Profile,SessionState) live across tests; never cache aFuturein them (each test runs in its own zone, and a Future from an earlier test never completes in the next). - Chat arrives twice from the server (see PROTOCOL.md); the client drops the textless feed copy.
- Tab traversal is disabled in the session player on purpose; Tab toggles chat & activity.
- After editing constants (ports, thresholds), grep to confirm the value landed.